Conversation
- Added support to pass `provider`. This is useful if you don't use the default provider name - Added support for microsoft: https://github.com/pond/omniauth-entra-id - Added support for oidc: https://github.com/omniauth/omniauth_openid_connect
|
Hi @jclusso Thanks for your contribution. I know working on Open Source requires valuable time. At the moment, we won't accept this because we are not introducing new/significant changes to existing generators. @thdaraujo and I are currently exploring different ways of loading the generators with the expectation to give the community the option to create their own generators/custom options without merging them in faker. This would reduce our load (we have lots of generators to update, maintain, etc.) while providing flexibility to users by adding external plugins. Once we have this going, I will let you know and you can contribute to faker by adding this option as a plugin. Closing in the meantime since we are focused on improving the existing ones. |
2 participants
Motivation / Background
provider. This is useful if you don't use the default provider nameFaker::Omniauth.microsoft(related: https://github.com/pond/omniauth-entra-id)Faker::Omniauth.oidc(related: https://github.com/omniauth/omniauth_openid_connect)Checklist
Before submitting the PR make sure the following are checked:
[Fix #issue-number]